Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1403162

Re: [PATCH 3/4] uio: introduce devicetree bindings for uio_dmem_genirq

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/4] uio: introduce devicetree bindings for uio_dmem_genirq
Date 2016-05-18 19:10 +0200
Message-ID <rAd8S-4Ww-17@gated-at.bofh.it> (permalink)
References <rzJDQ-2NX-19@gated-at.bofh.it> <rzJDQ-2NX-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 17, 2016 at 11:22:19AM +0200, Jan Viktorin wrote:
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  .../devicetree/bindings/uio/uio_dmem_genirq.txt          | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/uio/uio_dmem_genirq.txt

DT describes h/w. UIO is not a h/w block, so this does not belong in DT. 
A UIO vs. kernel driver is purely a kernel decision which shouldn't 
require a DT change.

The properties should be part of match data for a compatible string that 
needs them set. Or if they can be defined in a way that is actually a 
property of the h/w, then it would be acceptible. You'd still need to 
define compatible strings that the properties apply to.

Rob

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/4] uio: introduce devicetree bindings for uio_dmem_genirq Jan Viktorin <viktorin@rehivetech.com> - 2016-05-17 11:40 +0200
  Re: [PATCH 3/4] uio: introduce devicetree bindings for  uio_dmem_genirq Rob Herring <robh@kernel.org> - 2016-05-18 19:10 +0200
    Re: [PATCH 3/4] uio: introduce devicetree bindings for  uio_dmem_genirq Jan Viktorin <viktorin@rehivetech.com> - 2016-05-19 10:50 +0200
      Re: [PATCH 3/4] uio: introduce devicetree bindings for  uio_dmem_genirq Rob Herring <robh@kernel.org> - 2016-05-23 22:40 +0200

csiph-web