Re: CQ and RDMA READ/WRITE APIs

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: CQ and RDMA READ/WRITE APIs
Date	2016-05-18 16:10 +0200
Message-ID	<rAakG-39y-21@gated-at.bofh.it> (permalink)
References	(3 earlier) <rzuOu-1B1-13@gated-at.bofh.it> <rzvrh-25A-25@gated-at.bofh.it> <rzR8m-7vF-23@gated-at.bofh.it> <rzR8m-7vF-21@gated-at.bofh.it> <rzZIC-4vM-1@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 05/17/2016 10:48 PM, Parav Pandit wrote:
> Hi Doug,
> 
> On Tue, May 17, 2016 at 11:02 PM, Doug Ledford <dledford@redhat.com> wrote:
>> Nice catch there Bart.  That was well before my role as maintainer and
>> so settles things well enough for me.  IOW, I don't feel I need to worry
>> about trying to maintain the dual license nature of the RDMA stack as it
>> was broken long before I took over.  Thanks for pointing that out.
>>
> 
> Does it mean we can submit new code files under GPL only license?

You always could.

> I submitted RDMA cgroup related code in ib_core under GPLv2 only license.

You did and you didn't.  For instance, in patch 1/3, the new
cgroup_rdma.c file has a notice of GPLv2, but no notice of copyright, so
it's incomplete.  You need to put a copyright notice in the file too.
And in the file cgroup_rdma.h you have neither a copyright notice or a
license statement.  It's a plain file.

In patch 2/3, the file infiniband/core/cgroup.c has a copied dual
license (not necessary, it can be GPL only), but again, it is missing
the copyright notice.

You need to finish the conversation you and Christoph were having in
that thread, but you also need a v11 of the patchset that fixes the
copyright issues.

> Existing files which are calling those new APIs will continue to be
> dual license (similar to CQ and RDMA APIs)?

Yes.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD

Thread

Re: CQ and RDMA READ/WRITE APIs Christoph Hellwig <hch@lst.de> - 2016-05-16 13:50 +0200
  Re: CQ and RDMA READ/WRITE APIs Doug Ledford <dledford@redhat.com> - 2016-05-16 17:00 +0200
    Re: CQ and RDMA READ/WRITE APIs Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-16 19:50 +0200
      Re: CQ and RDMA READ/WRITE APIs Doug Ledford <dledford@redhat.com> - 2016-05-16 20:30 +0200
        Re: CQ and RDMA READ/WRITE APIs Doug Ledford <dledford@redhat.com> - 2016-05-17 19:40 +0200
          Re: CQ and RDMA READ/WRITE APIs Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-17 21:00 +0200
          Re: CQ and RDMA READ/WRITE APIs Parav Pandit <pandit.parav@gmail.com> - 2016-05-18 04:50 +0200
            Re: CQ and RDMA READ/WRITE APIs Doug Ledford <dledford@redhat.com> - 2016-05-18 16:10 +0200
              Re: CQ and RDMA READ/WRITE APIs Parav Pandit <pandit.parav@gmail.com> - 2016-05-18 18:00 +0200
      Re: CQ and RDMA READ/WRITE APIs Christoph Hellwig <hch@lst.de> - 2016-05-17 07:40 +0200
        Re: CQ and RDMA READ/WRITE APIs Christoph Lameter <cl@linux.com> - 2016-05-17 17:40 +0200
  Re: CQ and RDMA READ/WRITE APIs Doug Ledford <dledford@redhat.com> - 2016-05-16 17:30 +0200

csiph-web