Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403913

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Tony Lindgren <tony@atomide.com> writes:
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [160519 01:10]:
>> On 05/18/2016 10:30 PM, Tony Lindgren wrote:
>> > Ideally the adma support would be a separate loadable module,
>> > similar how the cppi41dma is a child of the OTG controller.
>> 
>> The Master DMA is part of the hsmmc IP block. If the same ADMA module is
>> present on other IPs it might be beneficial to have a helper library to handle
>> it (allocating the descriptor pool, wrinting, updating descriptors, etc).
>
> OK. Yeah if it's part of the MMC controller it makes no sense to
> separate it. So then the conecrns are using alternate DMA
> implementations and keeping PM runtime working :)
>
> BTW, Felipe mentioned that the best thing to do in the long run would
> be to set up sdhci-omap.c operating in ADMA mode.
>
> Felipe, care to summarize what you had in mind?

yeah, just write a new sdhci-omap.c to start moving away from
omap-hsmmc.c, just like it was done for 8250-omap.

At the beginning, it could be just the bare minimum to get it working
and slowly move over stuff like pm runtime, dmaengine, PIO. Move more
platforms over to that driver and, eventually, get rid of omap-hsmmc.c
altogether.

That way, development can be focussed on generic layers (SDHCI) to which
OMAP MMC controller is compliant (apart from the VERSION register
quirk).

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] dra7/omap4/omap5: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 1/3] mmc: host: omap_hsmmc: remove *use_dma* member Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 3/3] ARM: dts: dra7/omap4/omap5: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-18 12:30 +0200
      Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Tony Lindgren <tony@atomide.com> - 2016-05-18 21:40 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-19 08:20 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:10 +0200
          Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Tony Lindgren <tony@atomide.com> - 2016-05-19 17:00 +0200
            Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Felipe Balbi <balbi@kernel.org> - 2016-05-19 20:40 +0200
              Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-23 08:30 +0200
                Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Felipe Balbi <balbi@kernel.org> - 2016-05-23 09:20 +0200
                Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-23 10:10 +0200
      Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-19 08:10 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:10 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-18 13:10 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:30 +0200

csiph-web