Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402873

Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2

Show all headers | View raw

On 05/18/16 11:45, Kishon Vijay Abraham I wrote:
> omap hsmmc host controller has ADMA2 feature. Enable it here
> for better read and write throughput. Add a new dt binding
> "ti,use_adma" to enable ADMA2.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../devicetree/bindings/mmc/ti-omap-hsmmc.txt      |    1 +
>  drivers/mmc/host/omap_hsmmc.c                      |  320 ++++++++++++++++----
>  include/linux/platform_data/hsmmc-omap.h           |    1 +
>  3 files changed, 256 insertions(+), 66 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 74166a0..eb5ceec2 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -28,6 +28,7 @@ specifier is required.
>  dma-names: List of DMA request names. These strings correspond
>  1:1 with the DMA specifiers listed in dmas. The string naming is
>  to be "rx" and "tx" for RX and TX DMA requests, respectively.
> +ti,use_adma: enable adma2 feature

Do we have use case when you want to fall back to generic DMA instead of aDMA2?
IMHO if the driver supports aDMA2, it is going to use it instead of the
generic s/eDMA.
What I mean is:
the driver implements the aDMA2 support.
if the IP has support for aDMA2, then it is going to use it, otherwise it will
use the generic DMA.

-- 
Péter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] dra7/omap4/omap5: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 1/3] mmc: host: omap_hsmmc: remove *use_dma* member Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 3/3] ARM: dts: dra7/omap4/omap5: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
  [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-18 10:50 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-18 12:30 +0200
      Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Tony Lindgren <tony@atomide.com> - 2016-05-18 21:40 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-19 08:20 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:10 +0200
          Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Tony Lindgren <tony@atomide.com> - 2016-05-19 17:00 +0200
            Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Felipe Balbi <balbi@kernel.org> - 2016-05-19 20:40 +0200
              Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-23 08:30 +0200
                Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Felipe Balbi <balbi@kernel.org> - 2016-05-23 09:20 +0200
                Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-23 10:10 +0200
      Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-19 08:10 +0200
        Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:10 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-18 13:10 +0200
    Re: [RFC PATCH 2/3] mmc: host: omap_hsmmc: Enable ADMA2 Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-05-19 10:30 +0200

csiph-web