Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine

From	Clemens Ladisch <clemens@ladisch.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine
Date	2016-03-04 19:50 +0100
Message-ID	<r92Xz-2wT-105@gated-at.bofh.it> (permalink)
References	(3 earlier) <r8xh0-4sv-17@gated-at.bofh.it> <r8zLQ-6rX-15@gated-at.bofh.it> <r8Eiv-1kl-17@gated-at.bofh.it> <r8Uni-4Eo-67@gated-at.bofh.it> <r92Xy-2wT-81@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Felipe Ferreri Tonello wrote:
> On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch <clemens@ladisch.de> wrote:
>> Felipe Ferreri Tonello wrote:
>>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>>> But in what way was the old state machine not "proper"?
>>>
>>> Because it didn't reflect all the correct and possible MIDI states
>>
>> The whole point of the one-byte real-time messages is that they do not
>> affect the parsing of the surrounding MIDI stream.  So not making them
>> part of the state machine is the proper way of handling them.  (Also
>> see the flowchart in appendix A of the spec.)
>
> I really don't get your point. So why do we have a state machine at all?

To parse all the other messages.


Regards,
Clemens

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Clemens Ladisch <clemens@ladisch.de> - 2016-03-04 10:40 +0100
  Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-04 19:50 +0100
    Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Clemens Ladisch <clemens@ladisch.de> - 2016-03-04 19:50 +0100

csiph-web