Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine

From	Felipe Ferreri Tonello <eu@felipetonello.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine
Date	2016-03-04 19:50 +0100
Message-ID	<r92Xy-2wT-81@gated-at.bofh.it> (permalink)
References	(2 earlier) <r8mlB-5kg-11@gated-at.bofh.it> <r8xh0-4sv-17@gated-at.bofh.it> <r8zLQ-6rX-15@gated-at.bofh.it> <r8Eiv-1kl-17@gated-at.bofh.it> <r8Uni-4Eo-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Clemens, 

On March 4, 2016 8:07:40 AM GMT+00:00, Clemens Ladisch <clemens@ladisch.de> wrote:
>Felipe Ferreri Tonello wrote:
>> On 03/03/16 11:38, Clemens Ladisch wrote:
>>> But in what way was the old state machine not "proper"?
>>
>> Because it didn't reflect all the correct and possible MIDI states
>
>The whole point of the one-byte real-time messages is that they do not
>affect the parsing of the surrounding MIDI stream.  So not making them
>part of the state machine is the proper way of handling them.  (Also
>see the flowchart in appendix A of the spec.)

I really don't get your point. So why do we have a state machine at all? 

>
>> This patch doesn't change any functionality. But the important thing
>> here is that it improves the driver maintainability [...]
>
>Then I won't get in the way of this driver's maintainer.


Clemens, I really value your feedback. I just want to understand what's the problem of this patch. 

Felipe 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Thread

Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Clemens Ladisch <clemens@ladisch.de> - 2016-03-04 10:40 +0100
  Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-03-04 19:50 +0100
    Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine Clemens Ladisch <clemens@ladisch.de> - 2016-03-04 19:50 +0100

csiph-web