Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348505

Re: [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM framework

Show all headers | View raw

Hi Andrew,

On 26.02.2016 21:59, Andrew Lunn wrote:
> Add a regmap for accessing the EEPROM, and then use that with the
> NVMEM framework. Enable backwards compatibility in the NVMEM config,
> so that the 'eeprom' file in sys is provided by the framework.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---

[snip]

>  
> -static ssize_t
> -at25_bin_read(struct file *filp, struct kobject *kobj,
> -	      struct bin_attribute *bin_attr,
> -	      char *buf, loff_t off, size_t count)
> +static int at25_regmap_read(void *context, const void *reg, size_t reg_size,
> +			    void *val, size_t val_size)
>  {
> -	struct device		*dev;
> -	struct at25_data	*at25;
> -
> -	dev = kobj_to_dev(kobj);
> -	at25 = dev_get_drvdata(dev);
> +	struct at25_data *at25 = context;
> +	off_t offset = *(u32 *)reg;
> +	int err;
>  
> -	return at25_ee_read(at25, buf, off, count);
> +	err = at25_ee_read(at25, val, offset, val_size);
> +	if (err)
> +		return err;
> +	return 0;

return at25_ee_read(at25, val, offset, val_size);

>  }
>  

[snip]

>  
> -static ssize_t
> -at25_bin_write(struct file *filp, struct kobject *kobj,
> -	       struct bin_attribute *bin_attr,
> -	       char *buf, loff_t off, size_t count)
> +static int at25_regmap_write(void *context, const void *data, size_t count)
>  {
> -	struct device		*dev;
> -	struct at25_data	*at25;
> +	struct at25_data *at25 = context;
> +	const char *buf;
> +	u32 offset;
> +	size_t len;
> +	int err;
>  
> -	dev = kobj_to_dev(kobj);
> -	at25 = dev_get_drvdata(dev);
> +	memcpy(&offset, data, sizeof(offset));
> +	buf = (const char *)data + sizeof(offset);
> +	len = count - sizeof(offset);
>  
> -	return at25_ee_write(at25, buf, off, count);
> +	err = at25_ee_write(at25, buf, offset, len);
> +	if (err)
> +		return err;
> +	return 0;

return at25_ee_write(at25, buf, offset, len) is shorter.

>  }

--
With best wishes,
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:00 +0100
  [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:00 +0100
    Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 22:50 +0100
      Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2016-03-02 22:50 +0100
        Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-03 00:10 +0100
  [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 23:00 +0100
  [PATCHv7 4/7] eeprom: at25: Remove in kernel API for accessing the EEPROM Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 4/7] eeprom: at25: Remove in kernel API for accessing  the EEPROM Wolfram Sang <wsa@the-dreams.de> - 2016-02-28 22:10 +0100
  [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 23:10 +0100
      Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-03-02 23:30 +0100
        Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-03 00:20 +0100
  [PATCHv7 7/7] misc: at24: replace memory_accessor with nvmem_device_read Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 7/7] misc: at24: replace memory_accessor with  nvmem_device_read Wolfram Sang <wsa@the-dreams.de> - 2016-02-28 22:10 +0100
  [PATCHv7 1/7] nvmem: Add flag to export NVMEM to root only Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
  [PATCHv7 2/7] nvmem: Add backwards compatibility support for older EEPROM drivers. Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
  Re: [PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM Greg KH <gregkh@linuxfoundation.org> - 2016-03-02 02:00 +0100

csiph-web