Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348490

Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM framework

Show all headers | View raw

Hi Andrew,

On 26.02.2016 21:59, Andrew Lunn wrote:
> Add a regmap for accessing the EEPROM, and then use that with the
> NVMEM framework. Set the NVMEM config structure to enable backward, so
> that the 'eeprom' file in sys is provided by the framework.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---

[snip]

> +static int at24_regmap_read(void *context, const void *reg, size_t reg_size,
> +			    void *val, size_t val_size)
> +{
> +	struct at24_data *at24 = context;
> +	off_t offset = *(u32 *)reg;
> +	int err;
> +
> +	err = at24_read(at24, val, offset, val_size);
> +	if (err)
> +		return err;
> +	return 0;

return at24_read(at24, val, offset, val_size);

Minus 5 LoC.

> +}
> +
> +static int at24_regmap_write(void *context, const void *data, size_t count)
> +{
> +	struct at24_data *at24 = context;
> +	const char *buf;
> +	u32 offset;
> +	size_t len;
> +	int err;
> +
> +	memcpy(&offset, data, sizeof(offset));
> +	buf = (const char *)data + sizeof(offset);
> +	len = count - sizeof(offset);
> +
> +	err = at24_write(at24, buf, offset, len);
> +	if (err)
> +		return err;
> +	return 0;

return at24_write(at24, buf, offset, len);

Minus another 5 LoC.

--
With best wishes,
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:00 +0100
  [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:00 +0100
    Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 22:50 +0100
      Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2016-03-02 22:50 +0100
        Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-03 00:10 +0100
  [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM  framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 23:00 +0100
  [PATCHv7 4/7] eeprom: at25: Remove in kernel API for accessing the EEPROM Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 4/7] eeprom: at25: Remove in kernel API for accessing  the EEPROM Wolfram Sang <wsa@the-dreams.de> - 2016-02-28 22:10 +0100
  [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-02 23:10 +0100
      Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Andrew Lunn <andrew@lunn.ch> - 2016-03-02 23:30 +0100
        Re: [PATCHv7 6/7] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Vladimir Zapolskiy <vz@mleia.com> - 2016-03-03 00:20 +0100
  [PATCHv7 7/7] misc: at24: replace memory_accessor with nvmem_device_read Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
    Re: [PATCHv7 7/7] misc: at24: replace memory_accessor with  nvmem_device_read Wolfram Sang <wsa@the-dreams.de> - 2016-02-28 22:10 +0100
  [PATCHv7 1/7] nvmem: Add flag to export NVMEM to root only Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
  [PATCHv7 2/7] nvmem: Add backwards compatibility support for older EEPROM drivers. Andrew Lunn <andrew@lunn.ch> - 2016-02-26 21:10 +0100
  Re: [PATCHv7 0/7] Convert exiting EEPROM drivers to NVMEM Greg KH <gregkh@linuxfoundation.org> - 2016-03-02 02:00 +0100

csiph-web