Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()'

From	Andrey Smirnov <andrew.smirnov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()'
Date	2016-03-02 19:20 +0100
Message-ID	<r8jxp-3k9-21@gated-at.bofh.it> (permalink)
References	<r7VOq-3gD-5@gated-at.bofh.it> <r7VOq-3gD-17@gated-at.bofh.it> <r8ftM-8on-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 2, 2016 at 5:58 AM, Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
> Sorry for so late review comments,
>
>
> On 01/03/16 16:59, Andrey Smirnov wrote:
>>
>> Add 'of_nvmem_cell_from_device_node()' -- a function that allows to
>> obtain 'struct nvmem_cell' from a device tree node representing it. One
>> use-case for such a function would be to access nvmem cells with known
>> phandles.
>
>
> Totally missing the purpose of this new API, Why is of_nvmem_cell_get() not
> useful, its exactly doing same thing.
>
> Unless you randomly want to handle phandles without proper dt bindings.

That about sums up what I was trying to do. In my "composite" driver,
the way the layout of the cell is specified is a 3-element tuple
containing a phandle to nvmem cell, offset within that cell and the
size of the chunk to use, so in order to be able to use that phandle I
introduced this function.

Andrey

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()' Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-03-01 18:00 +0100
  Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()' Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-02 15:00 +0100
    Re: [RESEND RFC 1/3] nvmem: Add 'of_nvmem_cell_from_device_node()' Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-03-02 19:20 +0100

csiph-web