RE: [PATCH net 0/3] r8169:issues fix.

From	Hau <hau@realtek.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH net 0/3] r8169:issues fix.
Date	2016-03-02 17:40 +0100
Message-ID	<r8hYC-1Lj-23@gated-at.bofh.it> (permalink)
References	<r6mg3-tV-9@gated-at.bofh.it> <r7Z5D-5Mg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> I don't agree with changes #1 and #2.
> 
> If you are going to go to a model where every single configuration operation
> is recorded in software and performed at resume time, then really do it and
> fix it in the whole driver.  As currently coded you are leaving lots of known
> bugs in the driver.
> 
> #2 is even a worse situation.  If you are going to handle things this way you
> must sync the counters when the suspend happens, so that the statistics get
> call receives up to date values.

Thanks for your advice. I will send #3 patch first. Then modify #1 and #2 patch and resend these two patches.

 ------Please consider the environment before printing this e-mail.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net 0/3] r8169:issues fix. Chunhao Lin <hau@realtek.com> - 2016-02-26 09:50 +0100
  Re: [PATCH net 0/3] r8169:issues fix. David Miller <davem@davemloft.net> - 2016-03-01 21:30 +0100
    RE: [PATCH net 0/3] r8169:issues fix. Hau <hau@realtek.com> - 2016-03-02 17:40 +0100

csiph-web