Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1347002
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net 0/3] r8169:issues fix. |
| Date | 2016-03-01 21:30 +0100 |
| Message-ID | <r7Z5D-5Mg-9@gated-at.bofh.it> (permalink) |
| References | <r6mg3-tV-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Chunhao Lin <hau@realtek.com> Date: Fri, 26 Feb 2016 16:40:43 +0800 > This series of patches fix 3 issues that are listed below. > > Chunhao Lin (3): > r8169:fix nic sometimes doesn't work after changing the mac address. > r8169:eliminate error message in using ethtool -S when nic is down. > r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48 I don't agree with changes #1 and #2. If you are going to go to a model where every single configuration operation is recorded in software and performed at resume time, then really do it and fix it in the whole driver. As currently coded you are leaving lots of known bugs in the driver. #2 is even a worse situation. If you are going to handle things this way you must sync the counters when the suspend happens, so that the statistics get call receives up to date values.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net 0/3] r8169:issues fix. Chunhao Lin <hau@realtek.com> - 2016-02-26 09:50 +0100
Re: [PATCH net 0/3] r8169:issues fix. David Miller <davem@davemloft.net> - 2016-03-01 21:30 +0100
RE: [PATCH net 0/3] r8169:issues fix. Hau <hau@realtek.com> - 2016-03-02 17:40 +0100
csiph-web