Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1347864

Re: [PATCH] snic: correctly check for array overrun on overly long version number

Show all headers | View raw

On 26/02/16 4:28 am, "Colin King" <colin.king@canonical.com> wrote:

>From: Colin Ian King <colin.king@canonical.com>
>
>The snic version number is expected to be 4 decimals in the form like
>a netmask string with each number stored in an element in array v.
>However, there is an off-by-one check on the number of elements in v
>allowing one to pass a 5 decimal version number causing v[4] to be
>referenced, causing a buffer overrun.  Fix the off-by-one error by
>comparing to i > 3 rather than 4.
Acked-by: Narsimhulu Musini <nmusini@cisco.com>

>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/snic/snic_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/snic/snic_ctl.c b/drivers/scsi/snic/snic_ctl.c
>index aebe753..ab0e06b 100644
>--- a/drivers/scsi/snic/snic_ctl.c
>+++ b/drivers/scsi/snic/snic_ctl.c
>@@ -75,7 +75,7 @@ snic_ver_enc(const char *s)
> 			continue;
> 		}
> 
>-		if (i > 4 || !isdigit(c))
>+		if (i > 3 || !isdigit(c))
> 			goto end;
> 
> 		v[i] = v[i] * 10 + (c - '0');
>-- 
>2.7.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] snic: correctly check for array overrun on overly long version number Colin King <colin.king@canonical.com> - 2016-02-26 00:00 +0100
  RE: [PATCH] snic: correctly check for array overrun on overly long  version number "Seymour, Shane M" <shane.seymour@hpe.com> - 2016-03-01 06:40 +0100
  Re: [PATCH] snic: correctly check for array overrun on overly long  version number Ewan Milne <emilne@redhat.com> - 2016-03-01 18:30 +0100
  Re: [PATCH] snic: correctly check for array overrun on overly long version number "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-03-02 02:20 +0100
  Re: [PATCH] snic: correctly check for array overrun on overly long  version number "Narsimhulu Musini (nmusini)" <nmusini@cisco.com> - 2016-03-02 10:10 +0100

csiph-web