Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1347860
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Dmitry Vyukov <dvyukov@google.com> |
| Newsgroups | linux.kernel |
| Subject | Re: net/sctp: sock memory leak |
| Date | Wed, 02 Mar 2016 10:00:02 +0100 |
| Message-ID | <r8aNs-5fM-7@gated-at.bofh.it> (permalink) |
| References | <qLvQZ-30j-5@gated-at.bofh.it> <qRhBE-1AN-17@gated-at.bofh.it> <qRi4H-204-29@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qy9lg5d6RCJpoaMu+Bx6uTjenl4+14B2THS5x0emrrw=; b=M3lSx8ar0XKsAt5BP36Fgr/ZmoEVZKWFNx6hPEkIg9bDVFwSJxxjtgRqjo4WTPji7S USGtCl3Su7zH8xM3+GESRF0VuYYpJPNcnhig0av0JoFoiwTdB/F0Do/KhuMqz29xvwC7 droHrVwDWn2H/aI8orhbkiNjo+/S2WmDdFto9/uTCMAFerMQsXWSkrissP74dbvCeOwl ELC9B1/XgV2b7GDItY3leUOYxC9TyIm5QvdLL5eQcu0wBAXKa8z8RDn+mIVZYfnqc6JB ILhXUDg6egAn1Gq6klCeALe8LvWgD0yHmii/d1D6eitBpBm1vVkrat+gsqhluY0dt8ub +ULw== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qy9lg5d6RCJpoaMu+Bx6uTjenl4+14B2THS5x0emrrw=; b=WFsffiD3BVS/yKlXuvFwOzD/ry09aku1JEdWnPXk1VdVevVmUXkHmiSOyN7aN+bcwH Map5XC1hIZCxeGbG8bvq/721jXn30vtCTjbTVsB2HBenxZ0TFUlgMVPq3hSKfT9iAl7L hWGf37uV8fqNUQbWes5/CFX6UFNyLmkj7hrFpGLGw6R0gsUunZbqirDL7Di5MbQPUSQ5 evJtYcuNI7gy3jZqsAdjPLWSsLxzjgPGH22Bwp9qum+A25+2wGEbYhYfQi7Kh6qOKjPZ vRFxM2zSxW+SA7xq2I/sFt/ESN5veMwmLF39NHf84T/OS5qpE8BxgQO5sW48/7kygHg3 W5iw== |
| X-Gm-Message-State | AD7BkJITtHX+Hz4Oky6jP6G6X4WxX4GnIlNQ9k4l0EyhVC13uianXY+w+rpRfJ7VYQjcX8SibWz2o37br4BwtD1v |
| X-Received | by 10.28.92.13 with SMTP id q13mr3148603wmb.43.1456909030850; Wed, 02 Mar 2016 00:57:10 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 61 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Vlad Yasevich <vyasevich@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, "David S. Miller" <davem@davemloft.net>, linux-sctp@vger.kernel.org, netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, syzkaller <syzkaller@googlegroups.com>, Kostya Serebryany <kcc@google.com>, Alexander Potapenko <glider@google.com>, Sasha Levin <sasha.levin@oracle.com>, Eric Dumazet <edumazet@google.com> |
| X-Original-Date | Wed, 2 Mar 2016 09:56:51 +0100 |
| X-Original-Message-ID | <CACT4Y+ar4nQyTtUpWZU4YEGdmLiJ1F5QDS=80YmTuuUNG4MNpg@mail.gmail.com> |
| X-Original-References | <CACT4Y+bf9h=vVSb82Jdv2GeV1MQPg15LW_AcV2BOw-XbMfNetw@mail.gmail.com> <20160115184620.GE6074@mrl.redhat.com> <CACT4Y+Z6jY_n_cpmbFz366=JzoLX=u4Zc_o8gHFwJw8ApKf4zw@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1347860 |
Show key headers only | View raw
On Fri, Jan 15, 2016 at 8:11 PM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Fri, Jan 15, 2016 at 7:46 PM, Marcelo Ricardo Leitner > <marcelo.leitner@gmail.com> wrote: >> On Wed, Dec 30, 2015 at 09:42:27PM +0100, Dmitry Vyukov wrote: >>> Hello, >>> >>> The following program leads to a leak of two sock objects: >> ... >>> >>> On commit 8513342170278468bac126640a5d2d12ffbff106 (Dec 28). >> >> I'm afraid I cannot reproduce this one? >> I enabled dynprintk at sctp_destroy_sock and it does print twice when I >> run this test app. >> Also added debugs to check association lifetime, and then it was >> destroyed. Same for endpoint. >> >> Checking with trace-cmd, both calls to sctp_close() resulted in >> sctp_destroy_sock() being called. >> >> As for sock_hold/put, they are matched too. >> >> Ideas? Log is below for double checking > > > Hummm... I can reproduce it pretty reliably. > > [ 197.459024] kmemleak: 11 new suspected memory leaks (see > /sys/kernel/debug/kmemleak) > [ 307.494874] kmemleak: 409 new suspected memory leaks (see > /sys/kernel/debug/kmemleak) > [ 549.784022] kmemleak: 125 new suspected memory leaks (see > /sys/kernel/debug/kmemleak) > > I double checked via /proc/slabinfo: > > SCTPv6 4373 4420 2368 13 8 : tunables 0 0 > 0 : slabdata 340 340 0 > > SCTPv6 starts with almost 0, but grows infinitely while I run the > program in a loop. > > Here is my SCTP related configs: > > CONFIG_IP_SCTP=y > CONFIG_NET_SCTPPROBE=y > CONFIG_SCTP_DBG_OBJCNT=y > # CONFIG_SCTP_DEFAULT_COOKIE_HMAC_MD5 is not set > # CONFIG_SCTP_DEFAULT_COOKIE_HMAC_SHA1 is not set > CONFIG_SCTP_DEFAULT_COOKIE_HMAC_NONE=y > # CONFIG_SCTP_COOKIE_HMAC_MD5 is not set > # CONFIG_SCTP_COOKIE_HMAC_SHA1 is not set > > I am on commit 67990608c8b95d2b8ccc29932376ae73d5818727 and I don't > seem to have any sctp-related changes on top. Still happens on 4.5-rc6. Marcelo, try to apply my config (if yours differs), run the program in a parallel loop and check /proc/slabinfo (or kmemleak).
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: net/sctp: sock memory leak Dmitry Vyukov <dvyukov@google.com> - 2016-03-02 10:00 +0100 Re: net/sctp: sock memory leak Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-03-02 20:50 +0100
csiph-web