Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper
Date	2016-03-02 10:00 +0100
Message-ID	<r8aNs-5fM-3@gated-at.bofh.it> (permalink)
References	<r80O6-6VE-13@gated-at.bofh.it> <r88Vl-3T2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 02 March 2016 07:50:28 Manuel Lauss wrote:
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: stable@vger.kernel.org # v4.3
> > Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> > ---
> > I think this is now the last holdout of the irq_to_gpio function,
> > and it's been broken for a while. Maybe Ralf can queue it up through
> > the MIPS tree along with the other fix for irq_to_gpio?
> 
> It's not broken though..  this driver on current linus-git works fine!

Ah, so it doesn't actually need the gpio line then?

irq_to_gpio() unconditionally returns -EINVAL since 4.3, so the easiest
fix would be to remove the card-detect function in the driver, right?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper Arnd Bergmann <arnd@arndb.de> - 2016-03-01 23:20 +0100
  Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper Manuel Lauss <manuel.lauss@gmail.com> - 2016-03-02 08:00 +0100
    Re: [PATCH] pcmcia: db1xxx: use correct irq_to_gpio helper Arnd Bergmann <arnd@arndb.de> - 2016-03-02 10:00 +0100

csiph-web