Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350264
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS |
| Date | 2016-03-04 16:00 +0100 |
| Message-ID | <r8ZmV-8cW-1@gated-at.bofh.it> (permalink) |
| References | <r6cJH-27E-1@gated-at.bofh.it> <r6cJI-27E-25@gated-at.bofh.it> <r8jH4-3o2-3@gated-at.bofh.it> <r8N2q-7A3-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Mar 3, 2016 at 7:39 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
> Hi Rob,
>
> On 03/02/2016 12:26 PM, Rob Herring wrote:
>> On Thu, Feb 25, 2016 at 04:36:36PM -0600, Franklin S Cooper Jr wrote:
>>> From: Vignesh R <vigneshr@ti.com>
>>>
>>> Add PWMSS device tree nodes for DRA7 SoC family and add documentation
>>> for dt bindings.
>>>
>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>> ---
>>> Version 3 changes:
>>> None
>>>
>>> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 8 +++
>>> .../devicetree/bindings/pwm/pwm-tipwmss.txt | 17 +++++-
>>> arch/arm/boot/dts/dra7.dtsi | 64 ++++++++++++++++++++++
>>> 3 files changed, 88 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>>> index 9c100b2..25d91ae 100644
>>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>>> @@ -4,6 +4,7 @@ Required properties:
>>> - compatible: Must be "ti,<soc>-ehrpwm".
>>> for am33xx - compatible = "ti,am33xx-ehrpwm";
>>> for da850 - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>>> + for dra7xx - compatible = "ti,dra7xx-ehrpwm", "ti,am33xx-ehrpwm";
>> We're starting to push back on wildcards in compatible strings. I guess
>> this is okay...
>>
>>> - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>>> the cells format. The only third cell flag supported by this binding is
>>> PWM_POLARITY_INVERTED.
>>> @@ -27,3 +28,10 @@ ehrpwm0: ehrpwm@0 { /* EHRPWM on da850 */
>>> #pwm-cells = <3>;
>>> reg = <0x300000 0x2000>;
>>> };
>>> +
>>> +ehrpwm0: ehrpwm@0 { /* EHRPWM on dra7xx */
>> Should be pwm@48440200
>
> So the AM335x, AM437x and DA850 all use ehrpwm0:
> ehrpwm@<address>. Also the address of 0 simply follows the
> pattern used in the other binding examples in that doc. I
> can replace the 0 address in this patch and make another
> patch that fixes it for the other examples in that file. But
> in terms of switching from ehrpwm0:ehrpwm@<address> to
> ehrpwm0:pwm@<address> that would also require making changes
> to the various dtsis also. So is it worth making that
> change? If so I have no problem doing it.
Follow-up patches to fix are fine. Unit-address and reg mismatches are
going to start warning in dtc soon.
Rob
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
[PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tero Kristo <t-kristo@ti.com> - 2016-03-01 14:00 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:10 +0100
[PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 19:10 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:20 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 20:00 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:00 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 17:30 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 03:10 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-04 07:30 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 13:30 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-04 17:40 +0100
[PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
[PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-26 20:50 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:10 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Rob Herring <robh@kernel.org> - 2016-03-02 19:30 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 02:50 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Rob Herring <robh@kernel.org> - 2016-03-04 16:00 +0100
[PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Sekhar Nori <nsekhar@ti.com> - 2016-02-26 11:30 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-02-29 23:10 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-02-29 23:40 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:00 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-01 00:20 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 20:50 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-03 00:00 +0100
csiph-web