Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349673

Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for exported symbols

Show all headers | View raw

Dne 29.2.2016 v 04:48 Nicolas Pitre napsal(a):
> +# Filter out exported kernel symbol names advertised as warning pragmas
> +# by the preprocessor and write them to $(1). We must consider continuation
> +# lines as well: they start with a blank, or the preceeding line ends with
> +# a ':'. Anything else is passed through as is.
> +# See also __KSYM_DEP() in include/linux/export.h.
> +ksym_dep_filter = sed -n \
> +	-e '1 {x; $$!d}' \
> +	-e '/^ / {H; $$!d}' \
> +	-e 'x; /:$$/ {x; H; $$!d; s/^/ /; x}' \
> +	-e ':filter; /^.*KBUILD_AUTOKSYM_DEP: /! {p; b next}' \
> +	-e 's//KSYM_/; s/\n.*//; w $(1)' \
> +	-e ':next; $$!d' \
> +	-e '1 q; s/^/ /; x; /^ /! b filter'

This is unreadable and it does not work with my gcc version. I get
dependencies like

    $(wildcard include/config/ksym/simple/strtoull [enabled by default].h) \

Please use some other way, which does not require parsing the compiler
diagnostic messages. A straightforward solution is to do something
similar to genksyms: A separate preprocessor pass with -Dsomething that
leaves the EXPORT_SYMBOL statements alone and just collect their occurences.

Thanks,
Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/8] [PULL REQUEST] Trim unused exported kernel symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 6/8] create/adjust generated/autoksyms.h Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
    Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h Michal Marek <mmarek@suse.com> - 2016-03-03 23:20 +0100
      Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-03-04 03:00 +0100
  [PATCH v4 8/8] kconfig option for TRIM_UNUSED_KSYMS Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 2/8] allow for per-symbol configurable EXPORT_SYMBOL() Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
    Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Michal Marek <mmarek@suse.com> - 2016-03-04 00:00 +0100
      Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-03-04 03:50 +0100
        Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Michal Marek <mmarek@suse.com> - 2016-03-04 11:20 +0100
  [PATCH v4 7/8] kbuild: build sample modules along with the rest of the  kernel Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 4/8] kbuild: de-duplicate fixdep usage Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 1/8] kbuild: record needed exported symbols for modules Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 3/8] fixdep: accept extra dependencies on stdin Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 05:00 +0100

csiph-web