Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349622

Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h

Show all headers | View raw

Hi Nicolas,

sorry for the late review.

Dne 29.2.2016 v 04:48 Nicolas Pitre napsal(a):
> +set -e
> +
> +cur_ksyms_file="include/generated/autoksyms.h"
> +new_ksyms_file="include/generated/autoksyms.h.tmpnew"
> +
> +info() { [ "$quiet" != "silent_" ] && printf "  %-7s %s\n" "$1" "$2"; }

Using && as a shorthand for if-statements does not work when running in
-e mode. This particular line causes the script to fail in silent mode.
There other uses of && in the script are inside sub-shells, so they do
work, but it would be good to convert them to avoid breakage if the
script is edited later.


> +# Extract changes between old and new list and touch corresponding
> +# dependency files.
> +# Note: sort -m doesn't work well with underscore prefixed symbols so we
> +# use 'cat ... | sort' instead.
> +changed=$(
> +count=0
> +cat "$cur_ksyms_file" "$new_ksyms_file" | sort | uniq -u |

sort "$cur_ksyms_file" "$new_ksyms_file" ? sort -m probably does not
work, because the input files are not sorted.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/8] [PULL REQUEST] Trim unused exported kernel symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 6/8] create/adjust generated/autoksyms.h Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
    Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h Michal Marek <mmarek@suse.com> - 2016-03-03 23:20 +0100
      Re: [PATCH v4 6/8] create/adjust generated/autoksyms.h Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-03-04 03:00 +0100
  [PATCH v4 8/8] kconfig option for TRIM_UNUSED_KSYMS Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 2/8] allow for per-symbol configurable EXPORT_SYMBOL() Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
    Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Michal Marek <mmarek@suse.com> - 2016-03-04 00:00 +0100
      Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-03-04 03:50 +0100
        Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for  exported symbols Michal Marek <mmarek@suse.com> - 2016-03-04 11:20 +0100
  [PATCH v4 7/8] kbuild: build sample modules along with the rest of the  kernel Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 4/8] kbuild: de-duplicate fixdep usage Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 1/8] kbuild: record needed exported symbols for modules Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 04:50 +0100
  [PATCH v4 3/8] fixdep: accept extra dependencies on stdin Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-29 05:00 +0100

csiph-web