Re: [PATCH] i2c: imx: add slave support. v2

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: imx: add slave support. v2
Date	2016-03-03 22:40 +0100
Message-ID	<r8J8u-4LK-21@gated-at.bofh.it> (permalink)
References	<qVevx-6B0-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jan 26, 2016 at 07:14:40PM +0300, Dmitriy Baranov wrote:
> Add I2C slave provider using the generic slave interface.
> It also supports master transactions when the slave in the idle mode.
> 
> Issues:
> Changes work only in PIO mode (when driver doesn`t use DMA)

This is fine with me. We don't support block transfers currently in the
slave core anyhow.

> There are might be race conditions.

Can you name them

> +enum imx_i2c_slave_state {
> +	I2C_IMX_SLAVE_IDLE,
> +	I2C_IMX_SLAVE_IRQ,
> +	I2C_IMX_SLAVE_POLLING

Highlevel question first: Why do you have polling? Why would anyone not
want to use interrupts here?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] i2c: imx: add slave support. v2 Wolfram Sang <wsa@the-dreams.de> - 2016-03-03 22:40 +0100
  Re: [PATCH] i2c: imx: add slave support. v2 Maxim Syrchin <syrchin@dev.rtsoft.ru> - 2016-03-04 12:30 +0100

csiph-web