Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349304

Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page()

Show all headers | View raw

On Tue, Mar 01, 2016 at 10:54:50PM +0900, Joonsoo Kim wrote:
> 2016-03-01 3:04 GMT+09:00 Dan Williams <dan.j.williams@intel.com>:
> > On Mon, Feb 29, 2016 at 1:33 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> The addition of tracepoints to the page reference tracking had an
> >> unfortunate side-effect in at least one driver that calls put_page
> >> from its exit function, resulting in a link error:
> >>
> >> `.exit.text' referenced in section `__jump_table' of crypto/built-in.o: defined in discarded section `.exit.text' of crypto/built-in.o
> >>
> >> From a cursory look at that this driver, it seems that it may be
> >> doing the wrong thing here anyway, as the page gets allocated
> >> using 'alloc_page()', and should be freed using '__free_page()'
> >> rather than 'put_page()'.
> >>
> >> With this patch, I no longer get any other build errors from the
> >> page_ref patch, so hopefully we can assume that it's always wrong
> >> to call any of those functions from __exit code, and that no other
> >> driver does it.
> >>
> >> Fixes: 0f80830dd044 ("mm/page_ref: add tracepoint to track down page reference manipulation")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Acked-by: Dan Williams <dan.j.williams@intel.com>
> >
> > Vinod, will you take this one?
> 
> Problematic patch ("mm/page_ref: ~~~") is not yet merged one. It is on mmotm
> and this fix should go together with it or before it. I think that
> handling this fix by
> Andrew is easier to all.

Okay fine by me.

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto/async_pq: use __free_page() instead of put_page() Arnd Bergmann <arnd@arndb.de> - 2016-02-29 10:40 +0100
  Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page() Dan Williams <dan.j.williams@intel.com> - 2016-02-29 19:10 +0100
    Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page() Joonsoo Kim <js1304@gmail.com> - 2016-03-01 15:00 +0100
      Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page() Vinod Koul <vinod.koul@intel.com> - 2016-03-03 16:50 +0100
  Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page() Vlastimil Babka <vbabka@suse.cz> - 2016-03-04 10:10 +0100

csiph-web