Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344953

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

Show all headers | View raw

On Sat, Feb 27, 2016 at 12:38 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote:
>> A device is not able to use direct complete if its children do not
>> also use direct complete. Even though the SCSI layer leaves devices
>> runtime suspended, the way it does it still prevents its parent from
>> using direct complete.
>
> Okay.
>
> Do you need to provide ->complete() hook that then resumes the device
> when system is resumed (since the device resume hook is never called
> when direct_complete is set)? Along the lines of
> pm_complete_with_resume_check().

That's an interesting question. Part of direct complete is to leave
the device runtime suspended even after the system resumes if
possible. The comments in pm_complete_with_resume_check indicate that
the firmware may resume a device. I could see this happening with some
kind of SCSI device.

If this is possible, are we able to put the device back into a
consistent state (runtime suspended) by calling suspend for the scsi
device? If not, we might need to use pm_complete_with_resume_check for
the complete callback.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] PM / sleep: Check legacy pm callbacks for direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
  [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
    Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-27 08:30 +0100
      Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-02-27 09:20 +0100
        Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-27 09:40 +0100
          Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-02-27 10:10 +0100
            Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-29 11:20 +0100
  [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
    Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-28 02:30 +0100
      Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-03-01 22:50 +0100

csiph-web