Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342546

[PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete

Show all headers | View raw

This tries to runtime suspend devices that are still active for direct
complete. This is for cases such as autosuspend delays which leaves
devices able to runtime suspend but still active. It's beneficial in
this case to runtime suspend the device to take advantage of direct
complete when possible.

Signed-off-by: Derek Basehore <dbasehore@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
---
 drivers/base/power/main.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index e0017d9..9693032 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1380,7 +1380,12 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async)
 		goto Complete;
 
 	if (dev->power.direct_complete) {
-		if (pm_runtime_status_suspended(dev)) {
+		/*
+		 * Check if we're runtime suspended. If not, try to runtime
+		 * suspend for autosuspend cases.
+		 */
+		if (pm_runtime_status_suspended(dev) ||
+		    !pm_runtime_suspend(dev)) {
 			pm_runtime_disable(dev);
 			if (pm_runtime_status_suspended(dev))
 				goto Complete;
-- 
2.7.0.rc3.207.g0ac5344

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] PM / sleep: Check legacy pm callbacks for direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
  [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
    Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-27 08:30 +0100
      Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-02-27 09:20 +0100
        Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-27 09:40 +0100
          Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-02-27 10:10 +0100
            Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-29 11:20 +0100
  [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete Derek Basehore <dbasehore@chromium.org> - 2016-02-25 01:30 +0100
    Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-28 02:30 +0100
      Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete "dbasehore ." <dbasehore@chromium.org> - 2016-03-01 22:50 +0100

csiph-web