Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1341323

Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer
Date 2016-02-24 05:10 +0100
Message-ID <r5yVZ-7pJ-43@gated-at.bofh.it> (permalink)
References <r5lYK-6Bs-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Feb 23, 2016 at 02:16:32PM +0000, Richard Fitzgerald wrote:
> The debug logging of FLL calculations was confusing. Values were
> printed in hex without indicating this by a leading 0x, and
> despite these normally being required in decimal. Also where the
> register value isn't the actual value (it s a power-of-two or
> 0 means 1, 1 means 2, ...)  it was unclear whether the actual or
> register value was shown.

I think that stuff was originally based on the way the datasheets quote
things:

> -	arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n",

the hex(decimal) but there is certainly very familiar from some of
those.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ASoC: arizona: Make logging of FLL calculations clearer Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-02-23 15:20 +0100
  Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Mark Brown <broonie@kernel.org> - 2016-02-24 05:10 +0100
    Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-02-24 18:40 +0100
      Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Mark Brown <broonie@kernel.org> - 2016-02-25 03:00 +0100

csiph-web