Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342251

Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer

Show all headers | View raw

On 24/02/16 04:08, Mark Brown wrote:
> On Tue, Feb 23, 2016 at 02:16:32PM +0000, Richard Fitzgerald wrote:
>> The debug logging of FLL calculations was confusing. Values were
>> printed in hex without indicating this by a leading 0x, and
>> despite these normally being required in decimal. Also where the
>> register value isn't the actual value (it s a power-of-two or
>> 0 means 1, 1 means 2, ...)  it was unclear whether the actual or
>> register value was shown.
> I think that stuff was originally based on the way the datasheets quote
> things:
>
>> -	arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n",
> the hex(decimal) but there is certainly very familiar from some of
> those.
Indeed, and it was fine on the first codec. Now we've got various 
revisions of the FLL with some fields having different meanings, human 
error started to creep into interpreting the debug.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: arizona: Make logging of FLL calculations clearer Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-02-23 15:20 +0100
  Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Mark Brown <broonie@kernel.org> - 2016-02-24 05:10 +0100
    Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-02-24 18:40 +0100
      Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer Mark Brown <broonie@kernel.org> - 2016-02-25 03:00 +0100

csiph-web