Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1342489

Re: [PATCH 26/35] block: set op to REQ_OP

From kbuild test robot <lkp@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 26/35] block: set op to REQ_OP
Date 2016-02-24 23:20 +0100
Message-ID <r5PWO-2Ff-21@gated-at.bofh.it> (permalink)
References <r5NLl-PN-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi Mike,

[auto build test WARNING on next-20160224]
[cannot apply to dm/for-next v4.5-rc5 v4.5-rc4 v4.5-rc3 v4.5-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/mchristi-redhat-com/separate-operations-from-flags-in-the-bio-request-structs/20160225-041726
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   lib/crc32.c:148: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:148: warning: Excess function parameter 'tab' description in 'crc32_le_generic'
   lib/crc32.c:293: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:293: warning: Excess function parameter 'tab' description in 'crc32_be_generic'
   lib/crc32.c:1: warning: no structured comments found
>> block/blk-core.c:1248: warning: No description found for parameter 'op'
>> block/blk-core.c:1248: warning: No description found for parameter 'op'

vim +/op +1248 block/blk-core.c

da8303c6 block/blk-core.c          Tejun Heo      2011-10-19  1232   * @q: request_queue to allocate request from
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1233   * op: REQ_OP_READ/REQ_OP_WRITE
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1234   * @op_flags: rq_flag_bits
da8303c6 block/blk-core.c          Tejun Heo      2011-10-19  1235   * @bio: bio to allocate request for (can be %NULL)
a06e05e6 block/blk-core.c          Tejun Heo      2012-06-04  1236   * @gfp_mask: allocation mask
da8303c6 block/blk-core.c          Tejun Heo      2011-10-19  1237   *
d0164adc block/blk-core.c          Mel Gorman     2015-11-06  1238   * Get a free request from @q.  If %__GFP_DIRECT_RECLAIM is set in @gfp_mask,
d0164adc block/blk-core.c          Mel Gorman     2015-11-06  1239   * this function keeps retrying under memory pressure and fails iff @q is dead.
d6344532 drivers/block/ll_rw_blk.c Nick Piggin    2005-06-28  1240   *
da3dae54 block/blk-core.c          Masanari Iida  2014-09-09  1241   * Must be called with @q->queue_lock held and,
a492f075 block/blk-core.c          Joe Lawrence   2014-08-28  1242   * Returns ERR_PTR on failure, with @q->queue_lock held.
a492f075 block/blk-core.c          Joe Lawrence   2014-08-28  1243   * Returns request pointer on success, with @q->queue_lock *not held*.
^1da177e drivers/block/ll_rw_blk.c Linus Torvalds 2005-04-16  1244   */
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1245  static struct request *get_request(struct request_queue *q, int op,
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1246  				   int op_flags, struct bio *bio,
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1247  				   gfp_t gfp_mask)
^1da177e drivers/block/ll_rw_blk.c Linus Torvalds 2005-04-16 @1248  {
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1249  	const bool is_sync = rw_is_sync(op, op_flags) != 0;
450991bc drivers/block/ll_rw_blk.c Nick Piggin    2005-06-28  1250  	DEFINE_WAIT(wait);
a051661c block/blk-core.c          Tejun Heo      2012-06-26  1251  	struct request_list *rl;
a06e05e6 block/blk-core.c          Tejun Heo      2012-06-04  1252  	struct request *rq;
a051661c block/blk-core.c          Tejun Heo      2012-06-26  1253  
a051661c block/blk-core.c          Tejun Heo      2012-06-26  1254  	rl = blk_get_rl(q, bio);	/* transferred to @rq on success */
a06e05e6 block/blk-core.c          Tejun Heo      2012-06-04  1255  retry:
3cbf3506 block/blk-core.c          Mike Christie  2016-02-24  1256  	rq = __get_request(rl, op, op_flags, bio, gfp_mask);

:::::: The code at line 1248 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/35 v4] separate operations from flags in the bio/request structs mchristi@redhat.com - 2016-02-24 20:50 +0100
  [PATCH 31/35] block, fs: remove old REQ definitions. mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 14/35] hfsplus: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 22/35] drbd: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 20/35] dm: pass dm stats data dir instead of bi_rw mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 26/35] block: set op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
    Re: [PATCH 26/35] block: set op to REQ_OP kbuild test robot <lkp@intel.com> - 2016-02-24 23:20 +0100
  [PATCH 32/35] block: shrink bi_rw and bi_op mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 19/35] dm: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 24/35] xen: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 23/35] md/raid: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 28/35] blktrace: get op from req->op/bio->bi_op mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 29/35] ide cd: do not set REQ_WRITE on requests. mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 27/35] drivers: set request op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 21/35] bcache: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 16/35] nilfs: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 07/35] btrfs: have submit_one_bio users setup bio bi_op mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 10/35] btrfs: don't pass rq_flag_bits if there is a bio mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 03/35] block, fs, mm, drivers: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 15/35] mpage: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 06/35] direct-io: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 13/35] xfs: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 09/35] btrfs: update __btrfs_map_block for bi_op transition mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 04/35] fs: have submit_bh users pass in op and flags separately mchristi@redhat.com - 2016-02-24 21:10 +0100
  Re: [PATCH 00/35 v4] separate operations from flags in the  bio/request structs Christoph Hellwig <hch@infradead.org> - 2016-02-29 18:20 +0100
    Re: [PATCH 00/35 v4] separate operations from flags in the  bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2016-02-29 18:40 +0100

csiph-web