Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342402

[PATCH 29/35] ide cd: do not set REQ_WRITE on requests.

Show all headers | View raw

From: Mike Christie <mchristi@redhat.com>

The block layer will set the correct READ/WRITE operation flags/fields
when creating a request, so there is not need for drivers to set the
REQ_WRITE flag.

This patch is compile tested only.

Signed-off-by: Mike Christie <mchristi@redhat.com>
---
 drivers/ide/ide-cd_ioctl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c
index 474173e..5887a7a 100644
--- a/drivers/ide/ide-cd_ioctl.c
+++ b/drivers/ide/ide-cd_ioctl.c
@@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
 	   layer. the packet must be complete, as we do not
 	   touch it at all. */
 
-	if (cgc->data_direction == CGC_DATA_WRITE)
-		flags |= REQ_WRITE;
-
 	if (cgc->sense)
 		memset(cgc->sense, 0, sizeof(struct request_sense));
 
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/35 v4] separate operations from flags in the bio/request structs mchristi@redhat.com - 2016-02-24 20:50 +0100
  [PATCH 31/35] block, fs: remove old REQ definitions. mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 14/35] hfsplus: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 22/35] drbd: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 20/35] dm: pass dm stats data dir instead of bi_rw mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 26/35] block: set op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
    Re: [PATCH 26/35] block: set op to REQ_OP kbuild test robot <lkp@intel.com> - 2016-02-24 23:20 +0100
  [PATCH 32/35] block: shrink bi_rw and bi_op mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 19/35] dm: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 24/35] xen: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 23/35] md/raid: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 28/35] blktrace: get op from req->op/bio->bi_op mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 29/35] ide cd: do not set REQ_WRITE on requests. mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 27/35] drivers: set request op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 21/35] bcache: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 16/35] nilfs: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:00 +0100
  [PATCH 07/35] btrfs: have submit_one_bio users setup bio bi_op mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 10/35] btrfs: don't pass rq_flag_bits if there is a bio mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 03/35] block, fs, mm, drivers: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 15/35] mpage: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 06/35] direct-io: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 13/35] xfs: set bi_op to REQ_OP mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 09/35] btrfs: update __btrfs_map_block for bi_op transition mchristi@redhat.com - 2016-02-24 21:10 +0100
  [PATCH 04/35] fs: have submit_bh users pass in op and flags separately mchristi@redhat.com - 2016-02-24 21:10 +0100
  Re: [PATCH 00/35 v4] separate operations from flags in the  bio/request structs Christoph Hellwig <hch@infradead.org> - 2016-02-29 18:20 +0100
    Re: [PATCH 00/35 v4] separate operations from flags in the  bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2016-02-29 18:40 +0100

csiph-web