Groups > linux.kernel > #1342052

Re: [PATCH] ubi: Fix out of bounds write in volume update code

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ubi: Fix out of bounds write in volume update code
Date	2016-02-24 15:10 +0100
Message-ID	<r5IiE-5Ha-29@gated-at.bofh.it> (permalink)
References	<r4GLT-1wb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 21 Feb 2016 10:53:03 +0100
Richard Weinberger <richard@nod.at> wrote:

> ubi_start_leb_change() alloctes too few bytes.
> ubi_more_leb_change_data() will write up to req->upd_bytes +
> ubi->min_io_size bytes.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/mtd/ubi/upd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c
> index cfeaf0f..b7901ce 100644
> --- a/drivers/mtd/ubi/upd.c
> +++ b/drivers/mtd/ubi/upd.c
> @@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_device *ubi, struct ubi_volume *vol,
>  	vol->changing_leb = 1;
>  	vol->ch_lnum = req->lnum;
>  
> -	vol->upd_buf = vmalloc(req->bytes);
> +	vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size));
>  	if (!vol->upd_buf)
>  		return -ENOMEM;
>  



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ubi: Fix out of bounds write in volume update code Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-02-24 15:10 +0100

csiph-web