Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1338920
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] ubi: Fix out of bounds write in volume update code |
| Date | 2016-02-21 19:20 +0100 |
| Message-ID | <r4GLT-1wb-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
ubi_start_leb_change() alloctes too few bytes. ubi_more_leb_change_data() will write up to req->upd_bytes + ubi->min_io_size bytes. Cc: stable@vger.kernel.org Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/mtd/ubi/upd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c index cfeaf0f..b7901ce 100644 --- a/drivers/mtd/ubi/upd.c +++ b/drivers/mtd/ubi/upd.c @@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_device *ubi, struct ubi_volume *vol, vol->changing_leb = 1; vol->ch_lnum = req->lnum; - vol->upd_buf = vmalloc(req->bytes); + vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size)); if (!vol->upd_buf) return -ENOMEM; -- 1.8.4.5
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] ubi: Fix out of bounds write in volume update code Richard Weinberger <richard@nod.at> - 2016-02-21 19:20 +0100
csiph-web