Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340106

Re: [PATCH 1/8] tty: n_gsm: fix formatting errors

Show all headers | View raw

On 21.02.2016 22:30, Joe Perches wrote:
> On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
>> Minor formatting changes to remove errors and reduce number of
>> warnings produced by checkpatch.pl script.
> []
>> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> []
>> @@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr, 
>> int addr, int cr,
>>  		if (!(control & 0x01)) {
>>  			pr_cont("I N(S)%d N(R)%d",
>>  				(control & 0x0E) >> 1, (control & 0xE0) >> 5);
>> -		} else switch (control & 0x0F) {
>> +		} else
>> +			switch (control & 0x0F) {
>
> Please follow the brace rule for else uses where
> if one branch has braces, the other does too.

Thank you for noticing.

Should I resend this as a single patch or wait for more comments for v2 
series?


-Andrej

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 6/8] tty: n_gsm: add missing length field in control channel commands Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
    Re: [PATCH 1/8] tty: n_gsm: fix formatting errors Joe Perches <joe@perches.com> - 2016-02-21 23:40 +0100
      Re: [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic <ak77@tnode.com> - 2016-02-23 01:40 +0100
  Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-22 00:50 +0100
    Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic <ak77@tnode.com> - 2016-02-23 01:30 +0100

csiph-web