Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340100

Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station

Show all headers | View raw

On 21.02.2016 23:42, One Thousand Gnomes wrote:
> On Sun, 21 Feb 2016 22:38:29 +0100
> Andrej Krpic <ak77@tnode.com> wrote:
>
>> When using n_gsm you have to explicitly set it to work as a 
>> initiator
>> station. This led me to believe that it can also work as a 
>> responder.
snip
> This looks reasonable to me. It was never intended to work as a 
> responder
> but it seems clean enough to do so. Have you tested it against some 
> other
> modems with these changes applied ?

It has been tested against SIM900 (SIMCom) and M66 (Quectel).

> (I'm always wary of patches to this going in without testing on 
> actual
> modems, because the spec is complex and we are not the only ones with
> bugs)

While second and third patch don't change anything for initiator mode 
mux,
others certainly do.

> Also can you please cc these patches to
> 	xinhuix.pan@intel.com

This address got rejected. Yours and LKML's didn't.


-Andrej

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 6/8] tty: n_gsm: add missing length field in control channel commands Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
  [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic <ak77@tnode.com> - 2016-02-21 22:50 +0100
    Re: [PATCH 1/8] tty: n_gsm: fix formatting errors Joe Perches <joe@perches.com> - 2016-02-21 23:40 +0100
      Re: [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic <ak77@tnode.com> - 2016-02-23 01:40 +0100
  Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-22 00:50 +0100
    Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic <ak77@tnode.com> - 2016-02-23 01:30 +0100

csiph-web