Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1339420
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private |
| Date | 2016-02-22 13:00 +0100 |
| Message-ID | <r4XjJ-5i9-23@gated-at.bofh.it> (permalink) |
| References | <r4Wxk-4RK-17@gated-at.bofh.it> <r4WH0-4WG-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Feb 22, 2016 at 11:06:50AM -0000, Thomas Gleixner wrote:
> + event->pmu_private = box;
> +static inline struct intel_uncore_box *uncore_event_to_box(struct perf_event *event)
> +{
> + return event->pmu_private;
> +}
Do you really need this? That is, what is wrong with:
static inline struct intel_uncore_box *uncore_event_to_box(struct perf_event *event)
{
return uncore_pmu_to_box(event->pmu, event->cpu);
}
Which, after patch 12, should be fairly trivial, right?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 12:20 +0100
Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Peter Zijlstra <peterz@infradead.org> - 2016-02-22 12:50 +0100
Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 13:10 +0100
Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Peter Zijlstra <peterz@infradead.org> - 2016-02-22 13:00 +0100
Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 13:10 +0100
csiph-web