Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339413

Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private
Date 2016-02-22 12:50 +0100
Message-ID <r4Xa3-5ds-21@gated-at.bofh.it> (permalink)
References <r4Wxk-4RK-17@gated-at.bofh.it> <r4WH0-4WG-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 22, 2016 at 11:06:50AM -0000, Thomas Gleixner wrote:
> Index: b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> ===================================================================
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> @@ -313,6 +313,7 @@ static int snb_uncore_imc_event_init(str
>  		return -EINVAL;
>  
>  	event->cpu = box->cpu;
> +	event->pmu_private = pmu;

This seems rather pointless, did you want that to be '= box' instead?

>  
>  	event->hw.idx = -1;
>  	event->hw.last_tag = ~0ULL;
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch V2 10/28] x86/perf/intel_uncore: Store box in  event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 12:20 +0100
  Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in  event->pmu_private Peter Zijlstra <peterz@infradead.org> - 2016-02-22 12:50 +0100
    Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in  event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 13:10 +0100
  Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in  event->pmu_private Peter Zijlstra <peterz@infradead.org> - 2016-02-22 13:00 +0100
    Re: [patch V2 10/28] x86/perf/intel_uncore: Store box in  event->pmu_private Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 13:10 +0100

csiph-web