Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1338586
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Cong Wang <xiyou.wangcong@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino |
| Date | Sat, 20 Feb 2016 01:30:02 +0100 |
| Message-ID | <r43AS-55F-5@gated-at.bofh.it> (permalink) |
| References | <r3I3o-5VX-13@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fXaGiuRABdlvOPMkHVMoK49qC0umKKqn9ZOV5EFL0+Q=; b=iYsk0zn9GUk3f+9654Tlvfq/OPNKs603YSoj20OyuL+PLNsEcGy1NVIt+OBYuL0GRu v5PJhSLhEHFqnr/XLVFdu8uyxkA9BJzIq/2cD7fbdeAyjm6mKsJSdZGwY2lMFFO/i4KF elxwmuYCEgoyfraDeNPj/1ofddQYLGDp7443PV7DG0tVRTZvewd1y/6kuX1/J63JNyKY BgOO/sl6e4EZezEpKOd1yMrjlWTdVCBklv90hF5ftIU/1TX+wQZvLM6Fy+5lwHa9vX03 9VuxbEviryLEVGA4jRUjNjem0Oj8FtvCwVPO1CMzRnwQVFmey0oOTL+P1Y7VofyUEOI8 nFWw== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fXaGiuRABdlvOPMkHVMoK49qC0umKKqn9ZOV5EFL0+Q=; b=DlIkpjiXzHT93tD588fhY7olgiw32yFKmgNZTNrm+RvWd3Y9DaLRii1Bv5jd0wKg7Q xdrg5P9pFnJaixvzywPatYLVa4gK369BtLnIkPUy37QAXpjuD3DRTpgX5UaPOHz4zwRR Ze0vdXXsdxAn+luF1L9FUWZypyOk04I4UIjMEqF82Xu8htRi2nQN8+2rYsykVHAhFNg4 b09XudPOJtdVu2bDFBnsiTjpWAc+hWCmv4V449nbMsVyrr2e309SBgbcxOGRwJz9AYkd 2Z6tG3nD5BGExxgQL8oHzC76ivWdcIULsJiGVB0eknDkrvnR9eiKM6oafbIMFM32rRrH +/Yg== |
| X-Gm-Message-State | AG10YOT2uxLcv8zFoGP1ZmoGBLNdKbwBaUASWgxMKQ6U2L1quf59ZHqIq4FpaNC+vfcWYji3xCE4CFXyaixiNA== |
| MIME-Version | 1.0 |
| X-Received | by 10.37.83.136 with SMTP id h130mr8830507ybb.18.1455927674790; Fri, 19 Feb 2016 16:21:14 -0800 (PST) |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 18 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "David S. Miller" <davem@davemloft.net>, Pavel Emelyanov <xemul@parallels.com>, Linux Kernel Network Developers <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> |
| X-Original-Date | Fri, 19 Feb 2016 16:21:14 -0800 |
| X-Original-Message-ID | <CAM_iQpX4c7v2HbMG7cPi3T=HTHeEGhEQTSNS6CxX0tY=7KA4Uw@mail.gmail.com> |
| X-Original-References | <20160219012748.GA17251@altlinux.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1338586 |
Show key headers only | View raw
On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
> __u32, but unix_lookup_by_ino's argument ino has type int, which is not
> a problem yet.
> However, when ino is compared with sock_i_ino return value of type
> unsigned long, ino is sign extended to signed long, and this results
> to incorrect comparison on 64-bit architectures for inode numbers
> greater than INT_MAX.
>
> This bug was found by strace test suite.
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Cc: <stable@vger.kernel.org>
Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino "Dmitry V. Levin" <ldv@altlinux.org> - 2016-02-19 02:30 +0100
Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino Cong Wang <xiyou.wangcong@gmail.com> - 2016-02-20 01:30 +0100
Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino David Miller <davem@davemloft.net> - 2016-02-20 06:00 +0100
csiph-web