Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338586

Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

Show all headers | View raw

On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
> __u32, but unix_lookup_by_ino's argument ino has type int, which is not
> a problem yet.
> However, when ino is compared with sock_i_ino return value of type
> unsigned long, ino is sign extended to signed long, and this results
> to incorrect comparison on 64-bit architectures for inode numbers
> greater than INT_MAX.
>
> This bug was found by strace test suite.
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Cc: <stable@vger.kernel.org>

Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino "Dmitry V. Levin" <ldv@altlinux.org> - 2016-02-19 02:30 +0100
  Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino Cong Wang <xiyou.wangcong@gmail.com> - 2016-02-20 01:30 +0100
    Re: [PATCH] unix_diag: fix incorrect sign extension in  unix_lookup_by_ino David Miller <davem@davemloft.net> - 2016-02-20 06:00 +0100

csiph-web