Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337381

[PATCH 8/9] ARM: do not use optimized do_div for ARMv3

Show all headers | View raw

The gcc-4.9 optimization goes wrong while building target_core_iblock.c
for ARMv3 and leaves a bogus reference to __aeabi_uldivmod in the
output:

ERROR: "__aeabi_uldivmod" [drivers/target/target_core_iblock.ko] undefined!

I could not find anyone who is interested in fixing it in gcc,
so as a workaround this disables the do_div magic, just like
we do for old compilers and for OABI.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/include/asm/div64.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/include/asm/div64.h b/arch/arm/include/asm/div64.h
index 7d919a9b32e5..958fdc2363f5 100644
--- a/arch/arm/include/asm/div64.h
+++ b/arch/arm/include/asm/div64.h
@@ -58,6 +58,14 @@ static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
  */
 #define do_div(n, base) __div64_32(&(n), base)
 
+#elif defined(CONFIG_CPU_32v3)
+
+/*
+ * modern compiler versions (>= gcc-4.9) tend to misoptimize
+ * the code for ARMv3, and this is not getting fixed any more.
+ */
+#define do_div(n, base) __div64_32(&(n), base)
+
 #else
 
 /*
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 8/9] ARM: do not use optimized do_div for ARMv3 Arnd Bergmann <arnd@arndb.de> - 2016-02-18 15:10 +0100
  Re: [PATCH 8/9] ARM: do not use optimized do_div for ARMv3 Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-18 18:30 +0100
    Re: [PATCH 8/9] ARM: do not use optimized do_div for ARMv3 Arnd Bergmann <arnd@arndb.de> - 2016-02-19 10:10 +0100
      Re: [PATCH 8/9] ARM: do not use optimized do_div for ARMv3 Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-19 19:50 +0100

csiph-web