Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337120

[PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings

Show all headers | View raw

From: kbuild test robot <fengguang.wu@intel.com>

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
---
 drivers/rtc/rtc-max77686.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 5e924f3cde90..027ee7ebfff4 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -742,8 +742,8 @@ static int max77686_rtc_probe(struct platform_device *pdev)
 		goto err_rtc;
 	}
 
-	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
-				   "rtc-alarm1", info);
+	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq,
+				   IRQF_ONESHOT, "rtc-alarm1", info);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
 			info->virq, ret);
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Valentin Rothberg <valentin.rothberg@posteo.net> - 2016-02-18 09:10 +0100
  Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 09:20 +0100
    Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Valentin Rothberg <valentin.rothberg@posteo.net> - 2016-02-18 09:50 +0100
      Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 10:00 +0100
        Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Valentin Rothberg <valentin.rothberg@posteo.net> - 2016-02-18 10:10 +0100
    Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-18 10:00 +0100
      Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Valentin Rothberg <valentin.rothberg@posteo.net> - 2016-02-18 10:30 +0100

csiph-web