Re: [PATCH v5] ftrace/module: remove ftrace module notifier

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] ftrace/module: remove ftrace module notifier
Date	2016-02-17 22:20 +0100
Message-ID	<r3hFU-3GO-21@gated-at.bofh.it> (permalink)
References	<r2WrL-5HU-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 16 Feb 2016, Jessica Yu wrote:

> Remove the ftrace module notifier in favor of directly calling
> ftrace_module_enable() and ftrace_release_mod() in the module loader.
> Hard-coding the function calls directly in the module loader removes
> dependence on the module notifier call chain and provides better
> visibility and control over what gets called when, which is important
> to kernel utilities such as livepatch.
> 
> This fixes a notifier ordering issue in which the ftrace module notifier
> (and hence ftrace_module_enable()) for coming modules was being called
> after klp_module_notify(), which caused livepatch modules to initialize
> incorrectly. This patch removes dependence on the module notifier call
> chain in favor of hard coding the corresponding function calls in the
> module loader. This ensures that ftrace and livepatch code get called in
> the correct order on patch module load and unload.

Applied to for-4.5/upstream-fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] ftrace/module: remove ftrace module notifier Jessica Yu <jeyu@redhat.com> - 2016-02-16 23:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-17 03:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Miroslav Benes <mbenes@suse.cz> - 2016-02-17 09:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 21:40 +0100
    Re: [PATCH v5] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-17 21:40 +0100
      Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 21:50 +0100
        Re: [PATCH v5] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-17 22:10 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 22:20 +0100

csiph-web