Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336741

Re: [PATCH v5] ftrace/module: remove ftrace module notifier

Show all headers | View raw

On Wed, 17 Feb 2016 21:35:29 +0100 (CET)
Jiri Kosina <jikos@kernel.org> wrote:

> On Tue, 16 Feb 2016, Jessica Yu wrote:
> 
> > Remove the ftrace module notifier in favor of directly calling
> > ftrace_module_enable() and ftrace_release_mod() in the module loader.
> > Hard-coding the function calls directly in the module loader removes
> > dependence on the module notifier call chain and provides better
> > visibility and control over what gets called when, which is important
> > to kernel utilities such as livepatch.
> > 
> > This fixes a notifier ordering issue in which the ftrace module notifier
> > (and hence ftrace_module_enable()) for coming modules was being called
> > after klp_module_notify(), which caused livepatch modules to initialize
> > incorrectly. This patch removes dependence on the module notifier call
> > chain in favor of hard coding the corresponding function calls in the
> > module loader. This ensures that ftrace and livepatch code get called in
> > the correct order on patch module load and unload.
> > 
> > Fixes: 5156dca34a3e ("ftrace: Fix the race between ftrace and insmod")
> > Signed-off-by: Jessica Yu <jeyu@redhat.com>
> > Reviewed-by: Steven Rostedt <rostedt@goodmis.org>  
> 
> Steven, I am going to assume that your Reviewed-by: still holds for the 
> patch even though it has been removed from the 4-patch series; if you 
> don't agree, please speak up. Otherwise, I am going to apply it and push 
> it to Linus for -rc5 still (as it fixes our regression).
> 

This week has been very busy. Did the patch change at all?

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] ftrace/module: remove ftrace module notifier Jessica Yu <jeyu@redhat.com> - 2016-02-16 23:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-17 03:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Miroslav Benes <mbenes@suse.cz> - 2016-02-17 09:40 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 21:40 +0100
    Re: [PATCH v5] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-17 21:40 +0100
      Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 21:50 +0100
        Re: [PATCH v5] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-17 22:10 +0100
  Re: [PATCH v5] ftrace/module: remove ftrace module notifier Jiri Kosina <jikos@kernel.org> - 2016-02-17 22:20 +0100

csiph-web