Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1336575
| From | Vladimir Murzin <vladimir.murzin@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 |
| Date | 2016-02-17 17:50 +0100 |
| Message-ID | <r3dsD-BT-19@gated-at.bofh.it> (permalink) |
| References | <r2KJY-6rY-17@gated-at.bofh.it> <r2KTE-6wn-5@gated-at.bofh.it> <r2LG3-751-45@gated-at.bofh.it> <r2Qw2-1LV-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 16/02/16 16:10, Vladimir Murzin wrote:
> On 16/02/16 11:01, Arnd Bergmann wrote:
>> On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote:
>>> +
>>> + ethernet@40200000 {
>>> + compatible = "smsc,lan9220", "smsc,lan9115";
>>> + reg = <0x40200000 0x10000>;
>>> + interrupts = <13>;
>>> + interrupt-parent = <&nvic>;
>>> + smsc,irq-active-high;
>>> + };
>>> +};
>>> +
>>>
>>
>> This node seems slightly misplaced. Is there some external bus interface
>> that this is connected to? The address suggests that it should be somewhere
>> below the /soc node, and you probably want to list the external bus
>> interface with a "ranges" property that identifies the addresses visibile
>> there, and put the external chip under there.
>>
>
> I might messed it up since the MAC/PHY connects to the same 16-bit
> interface as the 16MB PSRAM external memory and both connected via AHB.
>
> Not sure how it should be expressed, so some help form DT camp would be
> appreciated.
Arnd,
Does following fixup address your point on where/how ethernet node
should be placed?
diff --git a/arch/arm/boot/dts/mps2-an385.dts b/arch/arm/boot/dts/an385.dts
index 976f86d..50c8d24 100644
--- a/arch/arm/boot/dts/mps2-an385.dts
+++ b/arch/arm/boot/dts/mps2-an385.dts
@@ -63,14 +63,10 @@
device_type = "memory";
reg = <0x21000000 0x1000000>;
};
+};
- ethernet@40200000 {
- compatible = "smsc,lan9220", "smsc,lan9115";
- reg = <0x40200000 0x10000>;
- interrupts = <13>;
- interrupt-parent = <&nvic>;
- smsc,irq-active-high;
- };
+&mb {
+ ranges = <0 0x40200000 0x10000>;
};
&uart0 {
diff --git a/arch/arm/boot/dts/mps2.dtsi b/arch/arm/boot/dts/mps2.dtsi
index 5d2c539..1673472 100644
--- a/arch/arm/boot/dts/mps2.dtsi
+++ b/arch/arm/boot/dts/mps2.dtsi
@@ -223,5 +223,21 @@
default-state = "off";
};
};
+
+ };
+
+ mb: smb {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ ethernet@0 {
+ compatible = "smsc,lan9220", "smsc,lan9115";
+ reg = <0x0 0x10000>;
+ interrupts = <13>;
+ interrupt-parent = <&nvic>;
+ smsc,irq-active-high;
+ };
};
};
Cheers
Vladimir
>
> Cheers
> Vladimir
>
>> Arnd
>>
>>
>>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/10] Support for Cortex-M Prototyping System Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 11:20 +0100
[PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 11:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Arnd Bergmann <arnd@arndb.de> - 2016-02-16 12:10 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 17:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-17 17:50 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Arnd Bergmann <arnd@arndb.de> - 2016-02-17 18:00 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-18 11:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Arnd Bergmann <arnd@arndb.de> - 2016-02-18 11:50 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-18 12:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Arnd Bergmann <arnd@arndb.de> - 2016-02-18 13:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-18 13:50 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 16:20 +0100
Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 16:40 +0100
[PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 11:20 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-16 11:40 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 14:20 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-16 14:20 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 14:40 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-16 15:10 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-16 17:20 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-19 10:50 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 11:00 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Peter Hurley <peter@hurleysoftware.com> - 2016-02-19 16:50 +0100
Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-19 17:30 +0100
[PATCH v3 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 11:20 +0100
[PATCH v3 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 11:20 +0100
Re: [PATCH v3 00/10] Support for Cortex-M Prototyping System Arnd Bergmann <arnd@arndb.de> - 2016-02-16 12:10 +0100
Re: [PATCH v3 00/10] Support for Cortex-M Prototyping System Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-16 17:20 +0100
csiph-web