Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336574

Re: [PATCH] Fix kfree bug in sendmsg and recvmsg

Show all headers | View raw

On Wed, Feb 17, 2016 at 11:38:05AM -0500, Joe Korty wrote:
> Fix kfree bug in recvmsg and sendmsg.
> 
> We cannot kfree(iov) when iov points to an array on the
> stack, as that has the potential of corrupting memory.
> 
> So re-introduce the if-stmt that used to protect kfree
> from this condition, code that was removed as part of
> a larger set of changes made by git commit da184284.

NAK.  You are misreading import_iovec():
        *iov = p == *iov ? NULL : p;
in the end will have iov replaced with NULL if we ended up using what
it originally pointed to.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fix kfree bug in sendmsg and recvmsg Joe Korty <joe.korty@ccur.com> - 2016-02-17 17:40 +0100
  Re: [PATCH] Fix kfree bug in sendmsg and recvmsg Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-17 17:50 +0100
    Re: [PATCH] Fix kfree bug in sendmsg and recvmsg Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-17 18:00 +0100
  Re: [PATCH] Fix kfree bug in sendmsg and recvmsg David Miller <davem@davemloft.net> - 2016-02-17 19:30 +0100

csiph-web