Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered
Date	2016-02-19 05:30 +0100
Message-ID	<r3KRB-7S9-7@gated-at.bofh.it> (permalink)
References	<r3Blf-16f-9@gated-at.bofh.it> <r3Blf-16f-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Javier,

Just a question...

> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index f4f36bba7be9..f3ce94ec73b5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  	} else {
> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;

shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
failure, not depending on the regulator itself.

Andi

>  		dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
>  	}

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-18 19:20 +0100
  Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but  not registered Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 05:30 +0100
  Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but  not registered Andi Shyti <andi.shyti@samsung.com> - 2016-02-19 05:30 +0100

csiph-web