Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337876

Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

Show all headers | View raw

On 19.02.2016 13:20, Andi Shyti wrote:
> Hi Javier,
> 
> Just a question...
> 
>> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
>> index f4f36bba7be9..f3ce94ec73b5 100644
>> --- a/drivers/thermal/samsung/exynos_tmu.c
>> +++ b/drivers/thermal/samsung/exynos_tmu.c
>> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>>  			return ret;
>>  		}
>>  	} else {
>> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
>> +			return -EPROBE_DEFER;
> 
> shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
> failure, not depending on the regulator itself.

Usually not because that would make this error path quite complicated
and difficult to keep consistent. If you choose this way then you will
have to probably extend the black list (e.g. EINVAL, some other)... or
use a white list.

Additionally the error codes can come from deeper layers. These layer
now can return ESOMETHING but later it might change to EDIFFERENT... you
cannot predict that.

Whatever the reason was (except defer), just ignore the regulator.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-18 19:20 +0100
  Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but  not registered Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 05:30 +0100
  Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but  not registered Andi Shyti <andi.shyti@samsung.com> - 2016-02-19 05:30 +0100

csiph-web