Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337836

Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation
Date 2016-02-19 03:20 +0100
Message-ID <r3IPL-6ud-1@gated-at.bofh.it> (permalink)
References <r2hHX-3rm-5@gated-at.bofh.it> <r2hHX-3rm-3@gated-at.bofh.it> <r3xKG-6WT-15@gated-at.bofh.it> <r3HgZ-5mf-3@gated-at.bofh.it> <r3Id4-61g-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On (02/19/16 10:39), Joonsoo Kim wrote:
[..]
> > not sure if it's worth mentioning in the comment, but the other
> > concern here is the performance impact of an extra function call,
> > I believe. otherwise, Joonsoo would just do:
> 
> It's very natural thing so I'm not sure it is worth mentioning.

agree.

> > and in mm/debug_page_ref.c
> >
> > void __page_ref_set(struct page *page, int v)
> > {
> >         if (trace_page_ref_set_enabled())
> >                 trace_page_ref_set(page, v);
> > }
> > EXPORT_SYMBOL(__page_ref_set);
> > EXPORT_TRACEPOINT_SYMBOL(page_ref_set);
> 
> It is what I did in v1.

ah... indeed. well, "That was a year ago, how am I suppose to remember"

	-ss

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation js1304@gmail.com - 2016-02-15 04:10 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-15 06:10 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-15 06:30 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-15 15:20 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-15 17:10 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-02-16 01:50 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-16 02:20 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-18 08:50 +0100
          Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-18 15:30 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-18 15:30 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-19 01:40 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-19 02:40 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-19 02:50 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-19 03:20 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-19 02:30 +0100

csiph-web