Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation

From	Joonsoo Kim <js1304@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation
Date	2016-02-15 15:20 +0100
Message-ID	<r2sal-27A-5@gated-at.bofh.it> (permalink)
References	<r2hHX-3rm-5@gated-at.bofh.it> <r2hHX-3rm-3@gated-at.bofh.it> <r2jA6-4JA-11@gated-at.bofh.it> <r2jTs-4Xm-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-02-15 14:28 GMT+09:00 Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com>:
> On (02/15/16 14:08), Sergey Senozhatsky wrote:
>>
>> will this compile with !CONFIG_TRACEPOINTS config?
>>

Yes, even if !CONFIG_TRACEPOINTS, it is compiled well.

> uh.. sorry, was composed in email client. seems the correct way to do it is
>
> +#if defined CONFIG_DEBUG_PAGE_REF && defined CONFIG_TRACEPOINTS
>
>  #include <linux/tracepoint-defs.h>
>
>  #define page_ref_tracepoint_active(t) static_key_false(&(t).key)
>
>  extern struct tracepoint __tracepoint_page_ref_set;
>  ...
>
>  extern void __page_ref_set(struct page *page, int v);
>  ...
>
> #else
>
>  #define page_ref_tracepoint_active(t) false
>
>  static inline void __page_ref_set(struct page *page, int v)
>  {
>  }
>  ...
>
> #endif
>
>
>
> or add a dependency of PAGE_REF on CONFIG_TRACEPOINTS in Kconfig.

Thanks for catching it.
I will add "depends on CONFIG_TRACEPOINTS" to Kconfig because
this feature has no meaning if !CONFIG_TRACEPOINTS.


Thanks.

Thread

[PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation js1304@gmail.com - 2016-02-15 04:10 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-15 06:10 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-15 06:30 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-15 15:20 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-15 17:10 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-02-16 01:50 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-16 02:20 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-18 08:50 +0100
          Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-18 15:30 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-18 15:30 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-19 01:40 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-19 02:40 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2016-02-19 02:50 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-19 03:20 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <js1304@gmail.com> - 2016-02-19 02:30 +0100

csiph-web