[tip:perf/core] perf/core: Remove bogus UP_CANCELED hotplug state

From	tip-bot for Thomas Gleixner <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/core] perf/core: Remove bogus UP_CANCELED hotplug state
Date	2016-02-17 13:30 +0100
Message-ID	<r39p0-6nX-25@gated-at.bofh.it> (permalink)
References	<r0mVt-wW-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  b4f75d44bed1bdbb14ac704bfc38f62a3675e591
Gitweb:     http://git.kernel.org/tip/b4f75d44bed1bdbb14ac704bfc38f62a3675e591
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 9 Feb 2016 20:11:20 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 17 Feb 2016 10:37:28 +0100

perf/core: Remove bogus UP_CANCELED hotplug state

If CPU_UP_PREPARE fails the perf hotplug code calls perf_event_exit_cpu(),
which is a pointless exercise. The cpu is not online, so the smp function
calls return -ENXIO. So the result is a list walk to call noops.

Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/20160209201007.682184765@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/events/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5946460..474ffea 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9286,7 +9286,6 @@ perf_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu)
 		perf_event_init_cpu(cpu);
 		break;
 
-	case CPU_UP_CANCELED:
 	case CPU_DOWN_PREPARE:
 		perf_event_exit_cpu(cpu);
 		break;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch 0/4] perf: Fix various cpu hotplug oddities Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
  [patch 2/4] perf: Remove the bogus and dangerous CPU_DOWN_FAILED  hotplug state Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
    [tip:perf/core] perf/core:   Remove the bogus and dangerous CPU_DOWN_FAILED hotplug state tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-02-17 13:30 +0100
  [patch 1/4] perf: Remove bogus UP_CANCELED hotplug state Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
    [tip:perf/core] perf/core: Remove bogus UP_CANCELED hotplug state tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-02-17 13:30 +0100

csiph-web