Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330634
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [patch 1/4] perf: Remove bogus UP_CANCELED hotplug state |
| Date | 2016-02-09 21:20 +0100 |
| Message-ID | <r0mVt-wW-37@gated-at.bofh.it> (permalink) |
| References | <r0mVr-wW-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
If CPU_UP_PREPARE fails the perf hotplug code calls perf_event_exit_cpu(), which is a pointless exercise. The cpu is not online, so the smp function calls return -ENXIO. So the result is a list walk to call noops. Remove it. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- kernel/events/core.c | 1 - 1 file changed, 1 deletion(-) --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9286,7 +9286,6 @@ perf_cpu_notify(struct notifier_block *s perf_event_init_cpu(cpu); break; - case CPU_UP_CANCELED: case CPU_DOWN_PREPARE: perf_event_exit_cpu(cpu); break;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 0/4] perf: Fix various cpu hotplug oddities Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
[patch 2/4] perf: Remove the bogus and dangerous CPU_DOWN_FAILED hotplug state Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
[tip:perf/core] perf/core: Remove the bogus and dangerous CPU_DOWN_FAILED hotplug state tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-02-17 13:30 +0100
[patch 1/4] perf: Remove bogus UP_CANCELED hotplug state Thomas Gleixner <tglx@linutronix.de> - 2016-02-09 21:20 +0100
[tip:perf/core] perf/core: Remove bogus UP_CANCELED hotplug state tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-02-17 13:30 +0100
csiph-web