Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1336056

Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly
Date 2016-02-17 06:20 +0100
Message-ID <r32GR-1JA-7@gated-at.bofh.it> (permalink)
References <r2U6D-4e2-25@gated-at.bofh.it> <r2U6D-4e2-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 16-02-16, 21:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Drop some lines of code from od_update() by arranging the statements
> in there in a more logical way.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_ondemand.c |   11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -175,14 +175,11 @@ static void od_update(struct cpufreq_pol
>  		/* No longer fully busy, reset rate_mult */
>  		policy_dbs->rate_mult = 1;
>  
> -		if (!od_tuners->powersave_bias) {
> -			__cpufreq_driver_target(policy, freq_next,
> -					CPUFREQ_RELATION_C);
> -			return;
> -		}
> +		if (od_tuners->powersave_bias)
> +			freq_next = od_ops.powersave_bias_target(policy,
> +								 freq_next,
> +								 CPUFREQ_RELATION_L);
>  
> -		freq_next = od_ops.powersave_bias_target(policy, freq_next,
> -					CPUFREQ_RELATION_L);
>  		__cpufreq_driver_target(policy, freq_next, CPUFREQ_RELATION_C);
>  	}
>  }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 21:10 +0100
  Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-17 06:20 +0100

csiph-web