Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1334668

Re: [PATCH] Documentation: SubmittingPatches: Add note about Reviewed-by tags

From Jonathan Corbet <corbet@lwn.net>
Newsgroups linux.kernel
Subject Re: [PATCH] Documentation: SubmittingPatches: Add note about Reviewed-by tags
Date 2016-02-15 18:50 +0100
Message-ID <r2vrB-4dy-35@gated-at.bofh.it> (permalink)
References <r1buV-zY-1@gated-at.bofh.it>
Organization LWN.net

Show all headers | View raw


On Thu, 11 Feb 2016 18:12:58 -0800
Florian Fainelli <f.fainelli@gmail.com> wrote:

> As is now common in a lot of organization having an internal code review
> process (be it through Gerritt or other tools), patches extracted from
> this review process and submitted to public mailing-lists will have
> pre-existing Reviewed-by tags. Add a note about why these tags exists,
> and what a maintainer could be doing with those. Some maintainers did
> complain before that these tags had to be added when the patches get
> submitted to the public, while some just ignored and took the patches
> as-is.

So I'll confess, I'm not quite sold on this one.  This is a document for
people looking to learn about how to submit patches; it is already far
too long, complex, and bureaucratic.  I'm not at all convinced that
adding suggestions for maintainers is appropriate here.

Is there a real problem that this patch is trying to solve?

Thanks,

jon

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Documentation: SubmittingPatches: Add note about Reviewed-by tags Florian Fainelli <f.fainelli@gmail.com> - 2016-02-12 03:20 +0100
  Re: [PATCH] Documentation: SubmittingPatches: Add note about  Reviewed-by tags Anup Patel <anup.patel@broadcom.com> - 2016-02-12 04:10 +0100
  Re: [PATCH] Documentation: SubmittingPatches: Add note about  Reviewed-by tags Markus Mayer <markus.mayer@broadcom.com> - 2016-02-12 19:30 +0100
  Re: [PATCH] Documentation: SubmittingPatches: Add note about  Reviewed-by tags Jonathan Corbet <corbet@lwn.net> - 2016-02-15 18:50 +0100
    Re: [PATCH] Documentation: SubmittingPatches: Add note about  Reviewed-by tags Scott Branden <scott.branden@broadcom.com> - 2016-02-15 19:20 +0100

csiph-web