Re: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles'

From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles'
Date	2016-02-15 19:20 +0100
Message-ID	<r2vUB-4Jg-7@gated-at.bofh.it> (permalink)
References	<r28bF-5jV-17@gated-at.bofh.it> <r2p2O-8en-7@gated-at.bofh.it> <r2tzr-2WJ-15@gated-at.bofh.it> <r2vrB-4dy-27@gated-at.bofh.it> <r2vKW-4Dk-15@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw


On 15/02/16 18:03, Russell King - ARM Linux wrote:
> On Mon, Feb 15, 2016 at 05:41:42PM +0000, Sudeep Holla wrote:
>> Sorry for missing this earlier, I could reproduce this on my TC2.
>> The issue is with card-detect gpio probing. It's not related to AMBA
>> probing as discussed on the mail thread.
>>
>> mfd_add_device adds devices with of_node when cell->of_compatible is
>> matched, but the device created is expected to be matched based on name
>> which the patch under discussion clearly breaks.
>
> If I'm understanding you correctly, you're saying that MFD re-adds
> platform devices with the of_node of a new platform device pointing
> to an existing of_node, but expects this new platform device to
> match a _different_ driver?
>

Sorry if I was not clear.

I don't think it re-adds. IIUC mfd cells are specified inside the
mfd device DT node. MFD adds devices for it's child nodes with the
associated device node but with the name specified by MFD cells
matching the compatible.

> Sounds like MFD needs fixing.  I've said this before: of_node's must
> _never_ be copied between different device structures, especially
> when they are on the _same_ bus - quite simply because the driver
> core _can_ match using the DT compatible.
>

I don't think that's happening in this case at-least. For example:

Device node compatible: arm,vexpress-sysreg
Child node compatible: arm,vexpress-sysreg,sys_mci

MFD device is created for above child node with name
"basic-mmio-gpio.<id>.auto" as it matched the MFD cell of_compatible

Since there's no driver to match "arm,vexpress-sysreg,sys_mci", it fails
with $subject patch applied which otherwise would do normal name matching

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-14 18:00 +0100
  Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-14 21:00 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-14 21:10 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 09:20 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 10:00 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 10:20 +0100
            Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 11:10 +0100
              Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 11:20 +0100
                Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 11:20 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-14 22:10 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 08:50 +0100
  Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 12:00 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Robin Murphy <robin.murphy@arm.com> - 2016-02-15 14:20 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 15:50 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 17:30 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 17:50 +0100
            Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 18:20 +0100
              Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 22:10 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-15 16:50 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 17:20 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 18:10 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-15 19:20 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 19:50 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 18:50 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 19:10 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 19:20 +0100

csiph-web