Re: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles'

From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles'
Date	2016-02-15 11:20 +0100
Message-ID	<r2oq5-7YN-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <r2b9x-7C4-37@gated-at.bofh.it> <r2mxZ-6JK-25@gated-at.bofh.it> <r2naG-6Yj-19@gated-at.bofh.it> <r2nu1-7kC-5@gated-at.bofh.it> <r2ogp-7VA-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Russell,

On Mon, Feb 15, 2016 at 10:04:15AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 15, 2016 at 10:14:06AM +0100, Uwe Kleine-König wrote:
> > On Mon, Feb 15, 2016 at 08:58:18AM +0000, Russell King - ARM Linux wrote:
> > > On Mon, Feb 15, 2016 at 09:17:50AM +0100, Uwe Kleine-König wrote:
> > > > On Sun, Feb 14, 2016 at 08:07:55PM +0000, Russell King - ARM Linux wrote:
> > > > > On Sun, Feb 14, 2016 at 08:55:01PM +0100, Uwe Kleine-König wrote:
> > > > > > So the unexpected abnormality here is that even though this device is
> > > > > > instantiated by dt, the driver doesn't provide any compatibles.
> > > > > > Either my expectation is wrong, then 67d02a1bbb33455 should be reverted
> > > > > 
> > > > > Your expectation is wrong.  AMBA primecell devices have hardware IDs
> > > > > and are matched to their drivers by those IDs.  Just like PCI.
> > > > 
> > > > pci devices don't appear in dt, do they? I don't see the connection
> > > > between amba devices and platform devices, see my other mail in this
> > > > thread for some more details.
> > > 
> > > They both have hardware IDs, and they are both matched via those hardware
> > > IDs.
> > 
> > I changed platform_match which is about matching by dt compatible, acpi
> > and/or device name. I don't see how this can affect an amba device given
> > they match to a driver by a hardware id.
> > 
> > > Your change has introduced a regression and is therefore wrong.
> > 
> > I'd like to understand though why and how my commit is wrong to be able
> > to fix it instead of getting it reverted.
> 
> I don't have the commit, and I haven't seen the patch so I can't
> comment further, sorry.

It's in -next. For a quick look:

	https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=67d02a1bbb33455

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Thread

arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-14 18:00 +0100
  Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-14 21:00 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-14 21:10 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 09:20 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 10:00 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 10:20 +0100
            Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 11:10 +0100
              Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 11:20 +0100
                Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 11:20 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-14 22:10 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 08:50 +0100
  Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 12:00 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Robin Murphy <robin.murphy@arm.com> - 2016-02-15 14:20 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 15:50 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 17:30 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 17:50 +0100
            Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 18:20 +0100
              Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 22:10 +0100
    Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-15 16:50 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 17:20 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-02-15 18:10 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Guenter Roeck <linux@roeck-us.net> - 2016-02-15 19:20 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 19:50 +0100
      Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 18:50 +0100
        Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-15 19:10 +0100
          Re: arm qemu test failures due to 'driver-core: platform: probe  of-devices only using list of compatibles' Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 19:20 +0100

csiph-web