Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334155

Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP update

Show all headers | View raw

> Now we can't depend for mm_cpumask, a parallel find_linux_pte_hugepte
> can happen outside that. Now i had a variant for kick_all_cpus_sync that
> ignored idle cpus. But then that needs more verification.
> 
> http://article.gmane.org/gmane.linux.ports.ppc.embedded/81105
Can be racy as a CPU moves from non-idle to idle

In

> +     pmd_hugepage_update(vma->vm_mm, address, pmdp, ~0UL, 0);
> +     /*
> +      * This ensures that generic code that rely on IRQ disabling
> +      * to prevent a parallel THP split work as expected.
> +      */
> +     kick_all_cpus_sync();

pmdp_invalidate()->pmd_hugepage_update() can still run in parallel with 
find_linux_pte_or_hugepte() and race.. Am I missing something?

Balbir Singh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP  update Balbir Singh <bsingharora@gmail.com> - 2016-02-15 03:50 +0100
  Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP update "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-02-15 05:40 +0100
    Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP  update Balbir Singh <bsingharora@gmail.com> - 2016-02-15 06:20 +0100
      Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP update "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-02-15 12:10 +0100
        Re: [PATCH V3] powerpc/mm: Fix Multi hit ERAT cause by recent THP  update Balbir Singh <bsingharora@gmail.com> - 2016-02-16 06:30 +0100

csiph-web